-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document extism.Json #20
base: main
Are you sure you want to change the base?
Conversation
|
||
@dataclass | ||
class User(extism.Json): | ||
admin: bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zshipko does there exist a way to provide the keyname if it differs from the property name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, we may have to add another decorator for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem, just checking
The macos install script test has been flaky for some reason, I need to spend some time fixing CI for this repo |
b2dcee7
to
73ec6e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I think if you rebase CI will pass. But since this doesn't touch the code we can probably just merge this as-is.
73ec6e4
to
746d3cd
Compare
Does this look correct @zshipko ? Is there maybe a test i can grab?