Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document extism.Json #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Document extism.Json #20

wants to merge 2 commits into from
+23 −2

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Oct 23, 2024 •
edited
Loading

Does this look correct @zshipko ? Is there maybe a test i can grab?

@bhelx bhelx requested a review from zshipko as a code owner October 23, 2024 15:36
bhelx
bhelx commented Oct 23, 2024
View reviewed changes
README.md

@dataclass
class User(extism.Json):
admin: bool
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zshipko does there exist a way to provide the keyname if it differs from the property name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, we may have to add another decorator for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, just checking

@zshipko
Copy link
Contributor

zshipko commented Oct 23, 2024

The macos install script test has been flaky for some reason, I need to spend some time fixing CI for this repo

@bhelx bhelx force-pushed the document-extism-json branch 2 times, most recently from b2dcee7 to 73ec6e4 Compare October 23, 2024 15:44
zshipko
zshipko approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I think if you rebase CI will pass. But since this doesn't touch the code we can probably just merge this as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhelx @zshipko