Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: free up memory after we're done with it #12

Merged
merged 5 commits into from
Aug 16, 2023
Merged

fix: free up memory after we're done with it #12

merged 5 commits into from
Aug 16, 2023

Conversation

mhmd-azeez
Copy link
Contributor

@mhmd-azeez mhmd-azeez commented Aug 15, 2023 •
edited
Loading

This PR makes sure we are free-ing up memory after we're done with it in Log, GetVar, SetVar, and SetVar

@mhmd-azeez
Copy link
Contributor Author

@zshipko Maybe we should remove this free here? I think the SDK should free the response body:

go-pdk/extism_pdk.go

Line 262 in 65bffbe

defer memory.Free()

@zshipko
Copy link
Contributor

zshipko commented Aug 15, 2023

@zshipko Maybe we should remove this free here? I think the SDK should free the response body:

go-pdk/extism_pdk.go

Line 262 in 65bffbe

defer memory.Free()

Yeah, good catch!

@nilslice nilslice merged commit ee09fee into extism:main Aug 16, 2023
2 checks passed
@mhmd-azeez mhmd-azeez deleted the fix/free branch August 16, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhmd-azeez @zshipko @nilslice