fix : Enable the post/postUpdate button after inserting dragged or pasted image into the news body - EXO-66290 #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofyenne
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
ahamdi
approved these changes
Sep 22, 2023
exo-swf
pushed a commit
that referenced
this pull request
Sep 22, 2023
…e news body - EXO-66290 (#931) Before this change, after inserting an image by pasting it into the news content, the 'Post' button continued to display as disabled. This issue was due to the 'onchange' event listener, which updated the news body by setting it to an empty value because the inserted image hadn't been uploaded yet. The same situation occurred with dragged images, which were handled by the 'drag' event listener with a one-second timeout to wait for the upload to finish. However, this approach was not satisfactory when dealing with a slow network connection. This change adds the 'afterInsertHtml' event listener, which is fired after data insertion. This ensures that the inserted image is uploaded and inserted into the editor, resolving the issue.
exo-swf
pushed a commit
that referenced
this pull request
Sep 25, 2023
…e news body - EXO-66290 (#931) Before this change, after inserting an image by pasting it into the news content, the 'Post' button continued to display as disabled. This issue was due to the 'onchange' event listener, which updated the news body by setting it to an empty value because the inserted image hadn't been uploaded yet. The same situation occurred with dragged images, which were handled by the 'drag' event listener with a one-second timeout to wait for the upload to finish. However, this approach was not satisfactory when dealing with a slow network connection. This change adds the 'afterInsertHtml' event listener, which is fired after data insertion. This ensures that the inserted image is uploaded and inserted into the editor, resolving the issue.
sofyenne
added a commit
that referenced
this pull request
Sep 26, 2023
…e news body - EXO-66290 (#931) Before this change, after inserting an image by pasting it into the news content, the 'Post' button continued to display as disabled. This issue was due to the 'onchange' event listener, which updated the news body by setting it to an empty value because the inserted image hadn't been uploaded yet. The same situation occurred with dragged images, which were handled by the 'drag' event listener with a one-second timeout to wait for the upload to finish. However, this approach was not satisfactory when dealing with a slow network connection. This change adds the 'afterInsertHtml' event listener, which is fired after data insertion. This ensures that the inserted image is uploaded and inserted into the editor, resolving the issue.
sofyenne
added a commit
that referenced
this pull request
Sep 26, 2023
…e news body - EXO-66290 (#931) Before this change, after inserting an image by pasting it into the news content, the 'Post' button continued to display as disabled. This issue was due to the 'onchange' event listener, which updated the news body by setting it to an empty value because the inserted image hadn't been uploaded yet. The same situation occurred with dragged images, which were handled by the 'drag' event listener with a one-second timeout to wait for the upload to finish. However, this approach was not satisfactory when dealing with a slow network connection. This change adds the 'afterInsertHtml' event listener, which is fired after data insertion. This ensures that the inserted image is uploaded and inserted into the editor, resolving the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, after inserting an image by pasting it into the news content, the 'Post' button continued to display as disabled. This issue was due to the 'onchange' event listener, which updated the news body by setting it to an empty value because the inserted image hadn't been uploaded yet. The same situation occurred with dragged images, which were handled by the 'drag' event listener with a one-second timeout to wait for the upload to finish. However, this approach was not satisfactory when dealing with a slow network connection.
This change adds the 'afterInsertHtml' event listener, which is fired after data insertion. This ensures that the inserted image is uploaded and inserted into the editor, resolving the issue.