feat: Display new target action of News list portlet drawer only for managers of web-contributors group - EXO-65909 - Meeds-io/MIPs#68 #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlhemEssaadi
force-pushed
the
Task/65909
branch
from
076a01b
to
d75bf96
Compare
…ist only for the group content manager - EXO-65909
IlhemEssaadi
force-pushed
the
Task/65909
branch
from
d75bf96
to
9673dce
Compare
azayati
requested changes
Aug 23, 2023
| @@ -68,9 +68,11 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| PortalHttpServletResponseWrapper responseWrapper = ( PortalHttpServletResponseWrapper ) rcontext.getResponse(); | |||
| String newsListUrl = "/portal/rest/v1/news/byTarget/" + newsTarget + "?offset=0&limit=" + limit + "&returnSize=true"; | |||
| responseWrapper.addHeader("Link", "<" + newsListUrl + ">; rel=prefetch; as=fetch; crossorigin=use-credentials", false); | |||
| boolean canManageNews = NewsUtils.canManageNewsPublishTargets(currentIdentity); | |||
There was a problem hiding this comment.
Suggested change
| boolean canManageNews = NewsUtils.canManageNewsPublishTargets(currentIdentity); | |
| boolean canManageNewsPublishTargets = NewsUtils.canManageNewsPublishTargets(currentIdentity); |
| %> | ||
| <div class="news-list-view-app" id="<%= appId %>"> | ||
| <script type="text/javascript"> | ||
| eXo.env.portal.canManageNews = <%=canManageNews%>; |
There was a problem hiding this comment.
Suggested change
| eXo.env.portal.canManageNews = <%=canManageNews%>; | |
| eXo.env.portal.canManageNewsPublishTargets = <%=canManageNewsPublishTargets %>; |
| @@ -31,7 +31,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| </v-card-text> | |||
| </v-card> | |||
| <news-settings-drawer v-if="canPublishNews" /> | |||
| <news-publish-targets-management-drawer v-if="canPublishNews" /> | |||
| <news-publish-targets-management-drawer v-if="canManageNews" /> | |||
There was a problem hiding this comment.
Suggested change
| <news-publish-targets-management-drawer v-if="canManageNews" /> | |
| <news-publish-targets-management-drawer v-if="canManageNewsPublishTargets " /> |
| @@ -104,6 +104,7 @@ export default { | |||
| hasMore: false, | |||
| offset: 0, | |||
| canPublishNews: false, | |||
| canManageNews: eXo.env.portal.canManageNews | |||
There was a problem hiding this comment.
Suggested change
| canManageNews: eXo.env.portal.canManageNews | |
| canManageNewsPublishTargets : eXo.env.portal.canManageNewsPublishTargets |
| @@ -102,7 +102,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| </template> | |||
| </v-select> | |||
| </div> | |||
| <div class="d-flex flex-row clickable text-decoration-underline"> | |||
| <div v-if="canManageNews" class="d-flex flex-row clickable text-decoration-underline"> | |||
There was a problem hiding this comment.
Suggested change
| <div v-if="canManageNews" class="d-flex flex-row clickable text-decoration-underline"> | |
| <div v-if="canManageNewsPublishTargets" class="d-flex flex-row clickable text-decoration-underline"> |
| @@ -197,7 +197,8 @@ export default { | |||
| showArticleReactions: false, | |||
| showTooltip: false, | |||
| seeAllUrl: `${eXo.env.portal.context}/${eXo.env.portal.portalName}/news?filter=pinned`, | |||
| saveSettingsURL: '' | |||
| saveSettingsURL: '', | |||
| canManageNews: eXo.env.portal.canManageNews | |||
There was a problem hiding this comment.
Suggested change
| canManageNews: eXo.env.portal.canManageNews | |
| canManageNewsPublishTargets: eXo.env.portal.canManageNewsPublishTargets |
azayati
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
azayati
changed the title
IlhemEssaadi
added a commit
that referenced
this pull request
Aug 24, 2023
…managers of web-contributors group - EXO-65909 - Meeds-io/MIPs#68 (#919)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.