feat: Enhance news load resources using load-group - EXO-63805 #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakermi
force-pushed
the
TASK-63805
branch
7 times, most recently
from
bb56b66
to
d1de7f2
Compare
exo-swf
force-pushed
the
feature/devx
branch
4 times, most recently
from
9ad61fb
to
7487c06
Compare
rdenarie
requested changes
Aug 17, 2023
Prior to this change, all news extensions were loaded inside all-bottom-container including the non needed once in all pages. This PR add the use of load-group mechanism to enhance the resources load and load only what is needed in the current page.
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
|
Kudos, SonarCloud Quality Gate passed! |
Done |
rdenarie
reviewed
Aug 17, 2023
Comment on lines
+583
to
+589
| Identity userIdentity = identityManager.getOrCreateUserIdentity(currentIdentity.getUserId()); | ||
| if (userIdentity != null) { | ||
| news.setFavorite(favoriteService.isFavorite(new Favorite("news", | ||
| news.getId(), | ||
| "", | ||
| Long.parseLong(userIdentity.getId())))); | ||
| } |
There was a problem hiding this comment.
why it should be removed? i have faced an existing old issue and i fixed it.
There was a problem hiding this comment.
the issue is that when access news details and that you have set the news as favorite, you will still have the option to set it again and the icon of favorite is empty icon which indicates that news is not marked as favorite while it's the case
| @@ -152,6 +152,7 @@ | |||
| activityId: '${activityId}', | |||
| hiddenSpace: ${news.hiddenSpace}, | |||
| isSpaceMember: ${news.isSpaceMember}, | |||
| favorite: ${news.isFavorite} | |||
There was a problem hiding this comment.
Why do you need this variable ?
hakermi
added a commit
that referenced
this pull request
Aug 18, 2023
Prior to this change, all news extensions were loaded inside all-bottom-container including the non needed once in all pages. This PR add the use of load-group mechanism to enhance the resources load and load only what is needed in the current page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, all news extensions were loaded inside all-bottom-container including the non needed once in all pages. This PR add the use of load-group mechanism to enhance the resources load and load only what is needed in the current page.