fix : Inserted images/videos aren't considred as a content in news - EXO-65311 #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exo-swf
force-pushed
the
feature/maintenance
branch
from
0c4a984
to
4992ade
Compare
ahamdi
reviewed
Aug 10, 2023
| @@ -395,23 +395,29 @@ export default { | |||
| editMode: function() { | |||
| return this.activityId && this.activityId !== ''; | |||
| }, | |||
| hasMediaContent() { | |||
| const parsedDocument = new DOMParser().parseFromString(this.news.body, 'text/html'); | |||
| const mediaElements = parsedDocument.querySelectorAll('img, video, iframe'); | |||
There was a problem hiding this comment.
Unfortunately this is still insufficient as it is limited to those tags and does not cover all possible HTML tags that could be added (svg, canva, audio, etc ...) even if it not the case now, but everytime a new tag is allowed, we will have to update the fix.
I prefer doing comparison of raw HTML content
sofyenne
force-pushed
the
Task/65311
branch
2 times, most recently
from
2b2d91a
to
88f99b3
Compare
exo-swf
force-pushed
the
feature/maintenance
branch
from
0eb2fcd
to
5bb122a
Compare
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
…play - EXO-65200 (#906) Prior to this change, when create news in three different space, go to news app, open hamburger drawer besides posted articles unselect all spaces and select only one space , copy the UI url and paste it in a new taw on notice the filter glitches, all news are displayed. After this change, the filter is already mentioned in the url.
exo-swf
force-pushed
the
feature/maintenance
branch
from
5bb122a
to
e330fbc
Compare
exo-swf
force-pushed
the
feature/maintenance
branch
from
e330fbc
to
f42fd66
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ahamdi
approved these changes
Aug 15, 2023
sofyenne
added a commit
that referenced
this pull request
Aug 15, 2023
…XO-65311 (#905) Before this change, when a user inserted an image or a video into the body of the news during the creation or modification process, the post button would be disabled. After this change, the post button is enabled when the news body isn't empty and the update button is enabled when a new content is inserted.
sofyenne
added a commit
that referenced
this pull request
Aug 15, 2023
…XO-65311 (#905) Before this change, when a user inserted an image or a video into the body of the news during the creation or modification process, the post button would be disabled. After this change, the post button is enabled when the news body isn't empty and the update button is enabled when a new content is inserted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when a user inserted an image or a video into the body of the news during the creation or modification process, the post button would be disabled. After this change, the post button is enabled when the news body isn't empty and the update button is enabled when a new content is inserted.