Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [NEWS] Filtered articles aren't retreived if they contain links - EXO-64780 #895

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

akhanfir
Copy link
Contributor

Prior to this change, when create an article with a link, open the news app, and filter articles by the keyword of the link, that article is not picked up in the filtered list. To fix this problem, add in the SQL query the search for this term in the property exo:body. After this change, this article is listed in the results.

@akhanfir akhanfir requested a review from ahamdi July 27, 2023 13:22
@akhanfir akhanfir enabled auto-merge (squash) July 27, 2023 13:22
@akhanfir akhanfir force-pushed the TASK-64780 branch 4 times, most recently from 0a90a26 to c5cec92 Compare July 31, 2023 09:48
@akhanfir akhanfir requested a review from ahamdi July 31, 2023 09:50
Copy link
Member

@ahamdi ahamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akhanfir my comment here is still relevent. where is this index added ? we should have the exact text without the fuy index

@akhanfir akhanfir requested a review from ahamdi August 1, 2023 08:59
@exo-swf exo-swf marked this pull request as draft August 1, 2023 09:01
auto-merge was automatically disabled August 1, 2023 09:01

Pull request was converted to draft

@exo-swf
Copy link
Contributor

exo-swf commented Aug 1, 2023

Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you

@akhanfir akhanfir force-pushed the TASK-64780 branch 2 times, most recently from 26f7002 to 67a47f6 Compare August 1, 2023 09:07
@akhanfir akhanfir marked this pull request as ready for review August 1, 2023 09:51
@akhanfir akhanfir enabled auto-merge (squash) August 1, 2023 09:51
EXO-64780

Prior to this change, when create an article with a link, open the news app, and filter articles by the keyword of the link, that article is not picked up in the filtered list. To fix this problem, add in the SQL query the search for this term in the property exo:body. After this change, this article is listed in the results.
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@akhanfir akhanfir requested a review from ahamdi August 3, 2023 11:25
@akhanfir akhanfir merged commit 78b1060 into feature/maintenance Aug 3, 2023
3 of 4 checks passed
@akhanfir akhanfir deleted the TASK-64780 branch August 3, 2023 11:32
akhanfir added a commit that referenced this pull request Aug 7, 2023
EXO-64780 (#895)

Prior to this change, when create an article with a link, open the news app, and filter articles by the keyword of the link, that article is not picked up in the filtered list. To fix this problem, add in the SQL query the search for this term in the property exo:body. After this change, this article is listed in the results.
akhanfir added a commit that referenced this pull request Aug 7, 2023
EXO-64780 (#895)

Prior to this change, when create an article with a link, open the news app, and filter articles by the keyword of the link, that article is not picked up in the filtered list. To fix this problem, add in the SQL query the search for this term in the property exo:body. After this change, this article is listed in the results.
akhanfir added a commit that referenced this pull request Aug 7, 2023
EXO-64780 (#895) (#901)

Prior to this change, when create an article with a link, open the news app, and filter articles by the keyword of the link, that article is not picked up in the filtered list. To fix this problem, add in the SQL query the search for this term in the property exo:body. After this change, this article is listed in the results.
akhanfir added a commit that referenced this pull request Aug 7, 2023
EXO-64780 (#895) (#902)

Prior to this change, when create an article with a link, open the news app, and filter articles by the keyword of the link, that article is not picked up in the filtered list. To fix this problem, add in the SQL query the search for this term in the property exo:body. After this change, this article is listed in the results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants