Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue in google translator connector with text contains single quote char - EXO-66886 #52

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: issue in google translator connector with text contains single quote char - EXO-66886 #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...n/java/org/exoplatform/automatic/translation/impl/connectors/DeepLTranslateConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public DeepLTranslateConnector(SettingService settingService) {
super(settingService);
textTranslationOptions = new TextTranslationOptions();
textTranslationOptions.setTagHandling("html");
textTranslationOptions.setPreserveFormatting(true);
textTranslationOptions.setSentenceSplittingMode(SentenceSplittingMode.All);
}

Expand Down
2 changes: 1 addition & 1 deletion .../java/org/exoplatform/automatic/translation/impl/connectors/GoogleTranslateConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public class GoogleTranslateConnector extends AutomaticTranslationComponentPlugi

private static final String KEY_PARAM = "key";

private static final String DATA_PATTERN = "{'q': '{message}', 'target': '{targetLocale}'}";
private static final String DATA_PATTERN = "{\"q\": \"{message}\", \"target\": \"{targetLocale}\"}";

private static final int DEFAULT_POOL_CONNECTION = 100;

Expand Down
1 change: 0 additions & 1 deletion ...va/org/exoplatform/automatic/translation/impl/connectors/DeepLTranslateConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public void translate() throws NoSuchFieldException, IllegalAccessException, Dee
// Need real auth-key to have a real result
TextTranslationOptions textTranslationOptions = new TextTranslationOptions();
textTranslationOptions.setTagHandling("html");
textTranslationOptions.setPreserveFormatting(true);
textTranslationOptions.setSentenceSplittingMode(SentenceSplittingMode.All);
TextResult textResult = new TextResult("<h1>Hello</h1>", "fr");
Field textTranslationOptionsField = deepLTranslateConnector.getClass().getDeclaredField("textTranslationOptions");
Expand Down