Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvment: Rich text editor for the events description- EXO-73526 #687

Merged
merged 49 commits into from
Sep 3, 2024

Conversation

Telgou
Copy link

@Telgou Telgou commented Aug 30, 2024

  • added rich editor to the event description.
  • ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
  • Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.

aycherif and others added 30 commits July 5, 2024 09:41
exoplatform#673)

* Corrected the ics generation function, added translation for the event's description
* Added conditional display based on a FeatureFlag
…platform#674)

* Improvment : Adding download button for ICS file - EXO-73522

* Corrected the ics generation function, added translation for the event's description

* Added conditional display based on FeatureFlag

* fix: ics generation if there is no conference url - EXO-73523
Added specific field required by Google Calendar to import an ICS file
exoplatform#673)

* Corrected the ics generation function, added translation for the event's description
* Added conditional display based on a FeatureFlag
…platform#674)

* Improvment : Adding download button for ICS file - EXO-73522

* Corrected the ics generation function, added translation for the event's description

* Added conditional display based on FeatureFlag

* fix: ics generation if there is no conference url - EXO-73523
Added specific field required by Google Calendar to import an ICS file
…orm#677)

Added the description field for plain text, for Calendar clients that do not use HTML description
exoplatform#673)

* Corrected the ics generation function, added translation for the event's description
* Added conditional display based on a FeatureFlag
…platform#674)

* Improvment : Adding download button for ICS file - EXO-73522

* Corrected the ics generation function, added translation for the event's description

* Added conditional display based on FeatureFlag

* fix: ics generation if there is no conference url - EXO-73523
Telgou and others added 10 commits August 23, 2024 14:23
exoplatform#673)

* Corrected the ics generation function, added translation for the event's description
* Added conditional display based on a FeatureFlag
…platform#674)

* Improvment : Adding download button for ICS file - EXO-73522

* Corrected the ics generation function, added translation for the event's description

* Added conditional display based on FeatureFlag

* fix: ics generation if there is no conference url - EXO-73523
Added specific field required by Google Calendar to import an ICS file
…orm#677)

Added the description field for plain text, for Calendar clients that do not use HTML description
…#682)



    Ensured that agenda connectors options are only displayed when there is at least one connector enabled by the admin.
    Updated the UI of the right column of the event details to match the current state of agenda connectors settings from both the user and administration sides.
@Telgou Telgou marked this pull request as ready for review August 30, 2024 14:57
@@ -213,6 +213,7 @@
<td style="color:#999999; font-size:13px;font-family:HelveticaNeue,arial,tahoma,serif; font-weight:bold"><%=_ctx.appRes("Notification.agenda.event.attendees")%></td>
<td align="left"><%= attendees %></td>
</tr>
<% try { %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we instead of addiong try/catch add the property to the list of properties in the notification object ?

@@ -192,6 +192,11 @@ export default {
};
},
computed: {
/* bodyElement() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the commented code ?

@@ -50,15 +57,37 @@ export default {
return result + line;
};

const foldDescription = (text) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check this code on how to convert HTML to plain text ?

@ahamdi ahamdi merged commit 5250d9a into exoplatform:feature/devx Sep 3, 2024
3 of 4 checks passed
exo-swf pushed a commit that referenced this pull request Sep 9, 2024
)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
exo-swf pushed a commit that referenced this pull request Sep 12, 2024
)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
ahamdi pushed a commit to Telgou/agenda-ics that referenced this pull request Sep 16, 2024
…xoplatform#687)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
ahamdi pushed a commit to Telgou/agenda-ics that referenced this pull request Sep 16, 2024
…xoplatform#687)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
exo-swf pushed a commit that referenced this pull request Sep 20, 2024
)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
ahamdi pushed a commit that referenced this pull request Sep 27, 2024
)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
exo-swf pushed a commit that referenced this pull request Sep 30, 2024
)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
exo-swf pushed a commit that referenced this pull request Sep 30, 2024
)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
exo-swf pushed a commit that referenced this pull request Oct 2, 2024
)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
exo-swf pushed a commit that referenced this pull request Oct 3, 2024
)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
exo-swf pushed a commit that referenced this pull request Oct 16, 2024
)

 - Added rich editor to the event description.
 - Ensured the new formatted description displays correctly when viewed on the platform and in programs after importing the ICS file.
 - Added try-catch block in email notif template to handle cases where the conference variable is not binded to ensure that the template does not throw a MissingPropertyException.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants