Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: partition by mem & node latency #330

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

thenatlog
Copy link

Pull Request: Add Partitioning Strategy Flag with Latency-Aware Default

Description

Feature Added

  • Partitioning Strategy Flag:
    • Introduced --partitioning-strategy CLI flag in main.py to allow selection between partitioning strategies.
    • Set latency_aware as the default partitioning strategy.

Implementation Details

  • Imports:
    • Imported LatencyAwarePartitioningStrategy alongside existing strategies.
  • Argument Parsing:
    • Updated main.py to parse the new --partitioning-strategy flag.
  • Strategy Selection:
    • Instantiated the selected partitioning strategy based on user input.
  • Node Initialization:
    • Modified StandardNode initialization to accept the chosen partitioning strategy.

Testing

  • New Tests:
    • Added TestLatencyAwarePartitioningStrategy in tests/test_latency_aware_partitioning.py to validate the new strategy.

Additional Changes

  • Protobuf Definitions:
    • Updated protobuf definitions to include latency in topology.
  • gRPC Files:
    • Regenerated node_service_pb2.py and node_service_pb2_grpc.py to reflect .proto updates.

Usage

Default (Latency-Aware)

python main.py run <model_name>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant