[Sublist] fix wording issue in instructions.md #1943
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The words "sublist" and "subsequence"1 mean different things.
They should not be used interchangeably.
Details
By the definition,
[1, 3]
is a subsequence of[1, 2, 3]
.However, the test
first_list_missing_element_from_second_list
requires these to beUnequal
, which is in contradiction with the instructions due to using the word "sub-sequence".https://github.com/mkovaxx/rust/blob/33b99f34188d03f35b08d0938d51a92763650d8c/exercises/practice/sublist/tests/sublist.rs#L134-L140
Footnotes
https://en.wikipedia.org/wiki/Subsequence ↩