Add test to ensure tera templates are in sync #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senekor
commented
Mar 27, 2024
Comment on lines
+4
to
+13
| fn test_no_items() { | ||
| let max_weight = 100; | ||
| let items = []; | ||
| let output = maximum_value(max_weight, &items); | ||
| let expected = 0; | ||
| assert_eq!(output, expected); | ||
| } | ||
|
|
||
| #[test] | ||
| #[ignore] |
There was a problem hiding this comment.
I think this is a normal update from problem-specifications.
| @@ -1,4 +1,4 @@ | |||
| use queen_attack::{ChessPiece, ChessPosition, Queen}; | |||
| use queen_attack::*; | |||
There was a problem hiding this comment.
This was inconsistent, must've been a mistake of mine. The change doesn't have any effect though.
| @@ -19,7 +19,7 @@ fn {{ test.description | slugify | replace(from="-", to="_") }}() { | |||
| 0x{{ byte | to_hex }}, | |||
| {%- endfor -%} | |||
| ]; | |||
| let output = vlq::{{ fn_names[1] }}(input); | |||
| let output = vlq::from_bytes(input); | |||
There was a problem hiding this comment.
fn_names[1] was failing for some reason, the explicit function name is more readable anyway.
| fn {{ test.description | slugify | replace(from="-", to="_") }}() { | ||
| let input = {{ test.input | json_encode() }}; | ||
| let input = {{ test.input.question | json_encode() }}; |
There was a problem hiding this comment.
Weird mistake, the test generation fails completely without .question.
Comment on lines
+2
to
+14
| { | ||
| "uuid": "88bf4b28-0de3-4883-93c7-db1b14aa806e", | ||
| "description": "exponential", | ||
| "comments": [ | ||
| "This test case was added a long time ago.", | ||
| "Upstreaming it would make the exercise more difficult." | ||
| ], | ||
| "property": "exponentials", | ||
| "input": { | ||
| "question": "What is 2 raised to the 5th power?" | ||
| }, | ||
| "expected": 32 | ||
| }, |
There was a problem hiding this comment.
These cases were in the finished test file, but test generation would remove them, because their not in canonical-data.json. I decided to keep them around, but not upstream them.
ErikSchierboom
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1878