Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotta-snatch-em-all: minor fixes #2771

Merged
merged 4 commits into from
Apr 4, 2024
Merged

gotta-snatch-em-all: minor fixes #2771

merged 4 commits into from
Apr 4, 2024

Conversation

sanderploegsma
Copy link
Contributor

Noticed some things that were missed in #2769:

  • The exercise name was not updated in config.json after generating the exercise with Configlet, so it was using the slug instead.
  • Found one mistake in the instructions left over from copy-pasting.
  • I forgot to add the Gradle wrapper

These are all addressed in this PR.

Reviewer Resources:

Track Policies

@sanderploegsma sanderploegsma added the x:size/small Small amount of work label Apr 4, 2024
@manumafe98
Copy link
Contributor

manumafe98 commented Apr 4, 2024 •
edited
Loading

@sanderploegsma This status value beta is correct?

manumafe98
manumafe98 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@manumafe98 manumafe98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other changes look good to me!

@sanderploegsma
Copy link
Contributor Author

@sanderploegsma This status value beta is correct?

Yea that is intentional, since it is a new exercise. See the meaning of it in the docs: https://exercism.org/docs/building/tracks/config-json#h-concept-exercises

@sanderploegsma sanderploegsma merged commit 1eb515e into main Apr 4, 2024
2 checks passed
@sanderploegsma sanderploegsma deleted the gotta-snatch-em-all-fixes branch April 4, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manumafe98 manumafe98 manumafe98 approved these changes

Assignees
No one assigned
Labels
x:size/small Small amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanderploegsma @manumafe98