Changing String format for String concatenation #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons of concept exercises
|
@sanderploegsma a bit weird, but I had to re run the workflows pipeline because it was stuck for 25 mins in the configlet one ps: I think is a general issue of github |
sanderploegsma
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request
As we are generally giving feedback on preferring string concatenation over string.format it makes sense to me that all our reference resolutions (at least for concept exercises) comply with that. Changing the practice ones seemed like a bit overkill, because normally we should give more freedom in those cases to students
Reviewer Resources:
Track Policies