Skip to content

Commit

Permalink
Expanding analyzer comment possibilities for log levels message and l…
Browse files Browse the repository at this point in the history
…oglevel methods (#2770)
  • Loading branch information
manumafe98 authored Apr 2, 2024
1 parent 0d27485 commit 098daf2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion exercises/concept/log-levels/.meta/design.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ This exercise could benefit from the following rules in the [analyzer]:

- `essential`: Verify that the solution does not hard-code the log levels (`[ERROR]:`, `[WARNING]:`, `[INFO]:`)
- `actionable`: If the student did not reuse the implementation of the `message` and `logLevel` methods in the `reformat` method, instruct them to do so.
- `actionable`: If the solution did not use `substring` in the methods `message` and `logLevel`, instruct the student to do so.
- `actionable`: If the solution did not use `split` or `substring` in the methods `message` and `logLevel`, instruct the student to do so.
- `informative`: If the solution uses `String.format` in the `reformat` method, inform the student that this cause a small performance penalty compared to string concatenation.

If the solution does not receive any of the above feedback, it must be exemplar.
Expand Down

0 comments on commit 098daf2

Please sign in to comment.