Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates grunt-node-tap so we have nicer output when feature tests fail #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eviltrout
Copy link
Contributor

No description provided.

@evilstreak
Copy link
Owner

I think this version of grunt-node-tap caused this issue: #174

@eviltrout
Copy link
Contributor Author

That error seemed about 1.4.5, this one is 1.5.2; locally I can run the default grunt task and everything works (with nicer output!). Maybe give it a shot locally and let me know if it's a problem?

@ashb
Copy link
Collaborator

ashb commented Feb 20, 2014

This works for me, but then pinning at version 0.1.48 which seemed to be the problem previously doesn't fail for me anymore

@jherdman Can you try this branch and let us know if npm test works for you with this?

@jherdman
Copy link
Contributor

npm test works fine, but grunt does not.

@eviltrout
Copy link
Contributor Author

What errors are you getting in grunt? Grunt works totally fine for me with
this version.

On Thu, Feb 20, 2014 at 2:33 PM, James Herdman [email protected]:

npm test works fine, but grunt does not.

Reply to this email directly or view it on GitHubhttps://github.com//pull/179#issuecomment-35659891
.

@jherdman
Copy link
Contributor

Fatal error: spawn ENOENT (stack trace is linked)

@ashb
Copy link
Collaborator

ashb commented Feb 20, 2014

I see the same:

% ./node_modules/.bin/grunt all
Running "node_tap:default_options" (node_tap) task
Fatal error: spawn ENOENT

Interestingly:

% PATH=./node_modules/.bin/:$PATH ./node_modules/.bin/grunt
Running "node_tap:default_options" (node_tap) task
Stats: ./test/features.t.js: 196/196
Stats: ./test/html_renderer.t.js: 2/2
Stats: ./test/interface.t.js: 3/3
Stats: ./test/regressions.t.js: 83/83
...

That works. What on earth is grunt-node-tap doing?

@ashb
Copy link
Collaborator

ashb commented Feb 20, 2014

I have raised an issue with grunt-node-tap - lets see if the author of it has any insights.

@eviltrout
Copy link
Contributor Author

That's so strange. I just confirmed again that both npm test and grunt all work correctly. It must be some kind of platform issue.

I'm on node v0.10.24

@jherdman
Copy link
Contributor

I'm on Node v0.10.26 on OS X if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants