Add e2e prerender-related tests #2630
Conversation
🦋 Changeset detectedLatest commit: ddf3be8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for evidence-test-env ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for evidence-development-workspace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for next-docs-evidence ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -11,7 +11,7 @@ import * as chartWindowDebug from './chartWindowDebug'; | |||
| * } ActionParams | |||
| */ | |||
|
|
|||
| const ANIMATION_DURATION = 500; | |||
| const ANIMATION_DURATION = navigator.webdriver ? 0 : 500; | |||
There was a problem hiding this comment.
Is this disabling animations in tests? If so, I don't think we should make this change. Testing in general is most effective when the code we're testing matches the code users are running. Adding differences like this reduces the effectiveness of testing.
If you added this to avoid adding delays to the tests, instead you should look for another way to know that the chart is fully mounted/animated (like a callback/flag) if that is important for the tests
There was a problem hiding this comment.
I did that so I could use the finished event to figure out chart rerenders - there's a rendered event I'm trying but it seems like it might not be very consistent
packages/ui/core-components/src/lib/atoms/inputs/dropdown/Dropdown.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/unsorted/viz/table/_DataTable.svelte
Show resolved
Hide resolved
|
@zachstence to check on why e2e tests aren't running here |
Seems fixed by resolving merge conflicts |
|
|
||
| // 3 renders is what is expected (creation -> update -> (deletion) -> creation) | ||
| // double loading makes 4 renders, adding another delete/create in | ||
| // TODO: why is 3 renders expected |
Description
Closes #2581
Adds tests for chart double loading, dropdown prerendering,
initialDatausage in page/input/manual queries, etca lot more can be added (i.e. one for each input, bigvalue test, etc) but I think this is a good start
Checklist