-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use theme color tokens #2628
Draft
zachstence
wants to merge
67
commits into
next
Choose a base branch
from
feat/2499-theming
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use theme color tokens #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find the “up” green in the big value comparison and elsewhere too light in the light mode. I find the various alert statuses not quite right in dark mode — I think it’d be worth exploring some transparency on their backgrounds in dark. |
@mcrascal FYI the screenshots are outdated, both of those have since been adjusted |
Ah sorry, trying to do it from my phone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expand sections below to see how different components look before and after theming changes
Page background, text, header, logo
Before:
After (light):
After (dark):
Markdown
Before:
After (light):
After (dark):
Alert
Before:
After (light):
After (dark):
Button
Before:
After (light):
After (dark):
Accordion
Before:
After (light):
After (dark):
BigLink
Before:
After (light):
After (dark):
Delta
Before:
After (light):
After (dark):
BigValue
Before:
After (light):
After (dark):
ButtonGroup
Before:
After (light):
After (dark):
Checkbox
Before:
After (light):
After (dark):
DataTable
Before:
After (light):
After (dark):
Checklist
- I have added to the VS Code extension where applicable