Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme color tokens #2628

Draft
wants to merge 67 commits into
base: next
Choose a base branch
from
Draft

Use theme color tokens #2628

wants to merge 67 commits into from

Conversation

zachstence
Copy link
Member

Description

Expand sections below to see how different components look before and after theming changes

Page background, text, header, logo

Before:
image

After (light):
image

After (dark):
image

Markdown

Before:
markdown before

After (light):
markdown after light

After (dark):
markdown after dark

Alert

Before:
image

After (light):
image

After (dark):
image

Button

Before:
button before

After (light):
button after light

After (dark):
button after dark

Accordion

Before:
image

After (light):
image

After (dark):
image

BigLink

Before:
image

After (light):
image

After (dark):
image

Delta

Before:
image
image
image
image

After (light):
image
image
image
image

After (dark):
image
image
image
image

BigValue

Before:
image

After (light):
image

After (dark):
image

ButtonGroup

Before:
image

After (light):
image

After (dark):
image

Checkbox

Before:
image
image

After (light):
image
image

After (dark):
image
image

DataTable

Before:
image

After (light):
image

After (dark):
image

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
    - I have added to the VS Code extension where applicable

@mcrascal
Copy link
Member

mcrascal commented Oct 9, 2024

I find the “up” green in the big value comparison and elsewhere too light in the light mode.

I find the various alert statuses not quite right in dark mode — I think it’d be worth exploring some transparency on their backgrounds in dark.

@archiewood
Copy link
Member

@mcrascal FYI the screenshots are outdated, both of those have since been adjusted

@mcrascal
Copy link
Member

mcrascal commented Oct 9, 2024

Ah sorry, trying to do it from my phone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants