Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed rendering layers Bubbles + Points #2612

Open
wants to merge 8 commits into
base: next
Choose a base branch
from

Conversation

kwongz
Copy link
Contributor

@kwongz kwongz commented Oct 4, 2024

Description

Points + Bubbles Layering inconsistency affecting chromatic checks.
This PR seperates Points and Bubbles into separate layers, ensuring Points layers on top of bubbles

Video:

  1. Multiple storybook refreshes showing points layered above bubbles
  2. 2 browser refreshes showing points layered above bubbles
map.layering.-.Made.with.Clipchamp.mp4

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • [ ] I have added to the docs where applicable
  • [ ] I have added to the VS Code extension where applicable

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 16d7c79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@evidence-dev/core-components Patch
my-evidence-project Patch
e2e-spa Patch
e2e-themes Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:59pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:59pm

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 16d7c79
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/670ee3c90dcbb70008a68da6
😎 Deploy Preview https://deploy-preview-2612--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit 16d7c79
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/670ee3c9d6f0640008edcd3d
😎 Deploy Preview https://deploy-preview-2612--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for evidence-test-env ready!

Name Link
🔨 Latest commit 16d7c79
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/670ee3c94f8b4600082d7947
😎 Deploy Preview https://deploy-preview-2612--evidence-test-env.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@zachstence zachstence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we have multiple <Points /> components and no <Bubbles /> components, how do we guarantee correct rendering order?

@kwongz
Copy link
Contributor Author

kwongz commented Oct 4, 2024

@zachstence looking into this now

@kwongz
Copy link
Contributor Author

kwongz commented Oct 15, 2024

  1. We are creating new panes depending on bubbles or points, to ensure the points are layered on top of bubbles.

image

  1. Users can use the new paneType and z prop to control multiple layers of points or bubbles

image

Note:
If users have 2 points in a basemap without panteType and z, the map layers the points pseudo-randomly (I believe whichever point renders first). We can try to automate this for this for the user.

@hughess
Copy link
Member

hughess commented Oct 15, 2024

@kwongz whats the syntax for pane type and z? And what would the user be specifying with those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants