Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates and Ruby 3.1 compatibility #63

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

robjlucas
Copy link

@robjlucas robjlucas commented Mar 9, 2021

No description provided.

Otherwise tests fail with thor warnings about open-ended version number
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ This is nice, thanks for taking the time to repair this!

@robjlucas
Copy link
Author

heart This is nice, thanks for taking the time to repair this!

Thanks for responding! You should probably look at these changes for Ruby 3 compatibility too.

I've been turning over different options for environment-specific config, and it occurred to me that this gem still does something that Rails encrypted credentials and environment-specific configs can't quite replicate, hence it seemed worth getting working with Ruby 3.

@robjlucas robjlucas changed the title Don't pin to specific thor version Dependency updates and Ruby 3.1 compatibility May 16, 2022
@yifeiwu
Copy link

yifeiwu commented May 24, 2022

Hey this looks good, any ETA on merging or should we start using the fork?

@cw-tigluiz
Copy link

Hello, there are any plans to merge this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants