Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an obsolete traverser that was shadowing the plone.restapi traverser #732

Merged
merged 1 commit into from
May 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ Changelog
(Fix regression introduced in https://github.com/euphorie/Euphorie/pull/692)
[ale-rt]

- Remove an obsolete traverser that was shadowing the plone.restapi traverser
[ale-rt]

- Delete guest account after sessions have been transferred
Ref: scrum-2155

Expand Down
5 changes: 0 additions & 5 deletions src/euphorie/deployment/browser/configure.zcml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@
xmlns:browser="http://namespaces.zope.org/browser"
>

<adapter
factory=".site.SitePublishTraverser"
provides="zope.publisher.interfaces.IPublishTraverse"
/>

<browser:page
name="nuplone-view"
for="Products.CMFPlone.interfaces.IPloneSiteRoot"
Expand Down
17 changes: 0 additions & 17 deletions src/euphorie/deployment/browser/site.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,14 @@
from plone.memoize.instance import memoize
from plone.memoize.view import memoize_contextless
from plone.protect.interfaces import IDisableCSRFProtection
from plonetheme.nuplone.skin.interfaces import NuPloneSkin
from Products.CMFCore.utils import getToolByName
from Products.CMFPlone.interfaces import IPloneSiteRoot
from Products.Five import BrowserView
from Products.membrane.interfaces.user import IMembraneUser
from sqlalchemy import and_
from sqlalchemy import sql
from time import time
from zope.component import adapter
from zope.deprecation import deprecate
from zope.interface import alsoProvides
from ZPublisher.BaseRequest import DefaultPublishTraverse

import logging

Expand All @@ -46,19 +42,6 @@ def __call__(self):
return self.request.response.redirect("%s/sectors/" % portal.absolute_url())


@adapter(IPloneSiteRoot, NuPloneSkin)
class SitePublishTraverser(DefaultPublishTraverse):
"""Publish traverser to manage access to the CMS API.

This traverser marks the request with IClientSkinLayer. We can not
use BeforeTraverseEvent since in Zope 2 that is only fired for site
objects.
"""

def publishTraverse(self, request, name):
return super().publishTraverse(request, name)


class EuphorieRefreshResourcesTimestamp(BrowserView):
@property
@memoize_contextless
Expand Down
Loading