Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show training certificates from other users in my organisation #731

Merged
merged 1 commit into from
May 15, 2024

Conversation

reinhardt
Copy link
Contributor

@reinhardt reinhardt commented May 8, 2024

The training certificate view was previously meant to only show the current user's certificates. Now it can take a parameter training_id that makes it display the training with the given id instead. The default is still to show the current user's certificate connected to the respective session (there can be only one such certificate per session). The parameter can also be passed to the index() method so that we don't have to fiddle with the request when displaying multiple certificates like in the overview page.

Ref syslabcom/scrum#2142

@reinhardt reinhardt requested review from thet and removed request for thet May 8, 2024 15:17
@reinhardt
Copy link
Contributor Author

Note to self: Process training_id in print view etc.

@reinhardt reinhardt force-pushed the scrum-2142-other-users-certificates branch from 273e077 to dc25cc2 Compare May 13, 2024 08:52
@reinhardt reinhardt marked this pull request as ready for review May 13, 2024 08:57
@reinhardt reinhardt requested a review from thet May 13, 2024 08:57
@cillianderoiste cillianderoiste requested review from cillianderoiste and removed request for thet May 14, 2024 10:02
@cillianderoiste cillianderoiste merged commit bcb6461 into main May 15, 2024
2 checks passed
@cillianderoiste cillianderoiste deleted the scrum-2142-other-users-certificates branch May 15, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants