Clean up references to guest accounts in last_modifier_id #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In acc2353 we changed `transferGuestSession` to update `last_modifier_id` and delete the guest account after all sessions have been transferred. This upgrade step does a similar thing with existing sessions. We don't update the modification date because we don't know when the session was transferred. We also double check that the guest account doesn't have any sessions associated with it so that we can safely delete it. Fixes syslabcom/scrum#2155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In acc2353 (#719) we changed
transferGuestSessionto updatelast_modifier_idand delete the guest account after all sessions have been transferred. This upgrade step does a similar thing with existing sessions. We don't update the modification date because we don't know when the session was transferred. We also double check that the guest account doesn't have any sessions associated with it so that we can safely delete it.Fixes syslabcom/scrum#2155