Add View find-solution-title-duplications #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinhardt
force-pushed
the
scrum-1550-solution-title-duplications
branch
from
42a57ca
to
6588c25
Compare
thet
requested changes
Oct 25, 2023
There was a problem hiding this comment.
I think I have found something, but I'm not sure. If the code is OK, feel free to merge.
Note: this will not do the check if the the title in the beginning of the text would be necessary for the semantic of the description. But this wasn't asked for in the first step either.
| ) | ||
| for brain in brains: | ||
| obj = brain.getObject() | ||
| if obj.description in obj.action: |
There was a problem hiding this comment.
shouldn't it be the other way around? assuming that obj.action is the title...
Suggested change
| if obj.description in obj.action: | |
| if obj.action in obj.description: |
There was a problem hiding this comment.
No, this is an oira weirdness. What the ticket calls the title is in the description attribute and what it calls the description is actually the action attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syslabcom/scrum#1550