Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euphorie notifications #656

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Euphorie notifications #656

merged 7 commits into from
Nov 17, 2023

Conversation

thet
Copy link
Member

@thet thet commented Oct 19, 2023

@thet thet marked this pull request as draft October 19, 2023 18:31
@ale-rt
Copy link
Member

ale-rt commented Oct 23, 2023

It does look like a reasonable start regarding the preferences storage.
There are some optimizations missing (e.g. a memoize here and there would do wonders) and some details missing (e.g. sorting).

One thing that I do not get is how you think to check that the notifications is sent.
Ok, you have notifications_sent table, but beside that I do not see any code that is going to use it.

@thet thet force-pushed the scrum-1572--reminders branch 4 times, most recently from 58c7227 to eeb99a9 Compare November 2, 2023 22:51
@thet thet marked this pull request as ready for review November 3, 2023 08:50
@reinhardt reinhardt self-requested a review November 3, 2023 09:12
src/euphorie/client/model.py Outdated Show resolved Hide resolved
src/euphorie/client/utils.py Outdated Show resolved Hide resolved
@thet thet force-pushed the scrum-1572--reminders branch 3 times, most recently from 88881b8 to 01541d6 Compare November 9, 2023 09:54
@thet thet force-pushed the scrum-1572--reminders branch 2 times, most recently from 61e90da to 3e9e39c Compare November 17, 2023 09:37
… preferences panel.

Note: the notification subscriptions are per default hidden.

Ref: scrum-1572
Add basic notification for risk assessments which were not modified
since a configurable number of days.

Note: This notification is disabled by default.

Ref: scrum-1572
@thet thet merged commit 5d1796f into main Nov 17, 2023
1 check passed
@thet thet deleted the scrum-1572--reminders branch November 17, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants