Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alembic upgrades fail-safe. #655

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Make alembic upgrades fail-safe. #655

merged 1 commit into from
Nov 3, 2023

Conversation

thet
Copy link
Member

@thet thet commented Oct 19, 2023

In order to run my own alembic upgrade I had to make all other not to fail first 😒

With these changes here I could finally run my upgrade steps.

Co-authored by GitHub Copilot, that saved me at least from some typing.

@thet thet requested review from reinhardt and ale-rt October 19, 2023 17:03
@ale-rt
Copy link
Member

ale-rt commented Oct 20, 2023

You should use alembic stamp to avoid running uneeded upgrade steps

@thet
Copy link
Member Author

thet commented Oct 20, 2023

Which I did. For some reason it seems to to have worked...
Probably a problem on my side then.

@thet thet merged commit 61cc837 into main Nov 3, 2023
1 check passed
@thet thet deleted the failsafe-alembic branch November 3, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants