Plone6 #603
Merged
Plone6 #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale-rt
force-pushed
the
plone6
branch
2 times, most recently
from
1c7b885
to
5dea889
Compare
ale-rt
force-pushed
the
plone6
branch
2 times, most recently
from
5ba2038
to
1f0281b
Compare
ale-rt
force-pushed
the
plone6
branch
3 times, most recently
from
8a1b1e6
to
de26211
Compare
ale-rt
force-pushed
the
plone6
branch
3 times, most recently
from
483ad59
to
bd0ed0a
Compare
thet
requested changes
Dec 21, 2023
| @@ -660,7 +659,6 @@ def fixed_priority(self, value): | |||
| self.default_priority = value | |||
|
|
|||
| @property | |||
| @memoize | |||
There was a problem hiding this comment.
I'm fine with using memoize sparsely and keep this change, but what problem does this solve?
Seems unrelated to the Plone 6 changes here.
There was a problem hiding this comment.
It broke some test for some reason I do not remember why
thet
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.