Create maps future change

[geek-yang]

• Implement new naming convention for maps
• Create maps for future change
• Use proper colorbard
• Use compact figure size
  This PR closes Uniform naming convention of maps from cpm/rcm/gcm data #41, closes Rename analysis to "future change" #42, fixes Check colorbar ranges #44, closes Colorbar takes up a lot of space #46 and fixes Precip unit #47

[Peter9192]

@geek-yang is this ready? If so, can you mark it ready for review, and request a review?

[geek-yang]

This PR is ready for review. Since there are too many maps, to make it easier for review, I created another tab called "future change" and this allows you to check those maps. Note that this tab will be nested in the "past performance" one as planned. We will handle it when addressing issue #43.

The sonarcloud complain is due to the duplication of tabs. We can ignore it for now.

[geek-yang]

The notebook used to generate all these maps is this. Since there are many exceptional cases (that's why there are many if statement in the code) in past performance and future change and they are therefore separated in this notebook.

[bvreede]

I don't know if this works, but this is the URL that directly refers to the PR review sans .png files.

[bvreede]

Looks good to me :)

[Peter9192]

Reviewed live yesterday, will wait for new changes.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
55.1% Duplication

[geek-yang]

@bvreede Thanks for your review, changes that you suggested have been implemented now.

@Peter9192 Thanks for spotting the mistake about the calculation. Now all maps are calculated as "future runs (rcp85)" minus "past runs (his)". All maps are regridded to 0.5 deg (otherwise the clipping tool does not work). This PR is ready for review again.

[Peter9192]

Hey @geek-yang thanks again for the hard work. I had a quick look and it seems better now. There might still be some tweaking and maybe some more bugs, but at this stage I think it's good to merge and share it with more people - then we're more likely to catch any remaining problems.

One small thing I noticed is that some maps seem to have coordinates between 0-360 instead of -180-180. For Europe, this leads to images like this:

Perhaps this can be addressed in a future PR.

[geek-yang]

Hey @geek-yang thanks again for the hard work. I had a quick look and it seems better now. There might still be some tweaking and maybe some more bugs, but at this stage I think it's good to merge and share it with more people - then we're more likely to catch any remaining problems.

One small thing I noticed is that some maps seem to have coordinates between 0-360 instead of -180-180. For Europe, this leads to images like this:

Perhaps this can be addressed in a future PR.

Thanks for your review @Peter9192 . I create a new issue for it #55 . We can address it later. I will merge this PR.