Raise when any records are invalid #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloconde
commented
Oct 14, 2024
| @@ -216,7 +216,7 @@ abstract class Producer[F[_], PutReq, PutRes] private[kinesis4cats] ( | |||
| ) | |||
| )(ref.get.flatMap(x => _put(x.inputRecords, x.retrying))) | |||
| _ <- | |||
| if (finalRes.hasFailed) { | |||
| if (finalRes.hasErrors) { | |||
There was a problem hiding this comment.
This is a change in behaviour. Before, you would only see invalid records if there was at least one failed record also. Does this change align with the documentation?
kinesis4cats/docs/smithy4s/getting-started.md
Line 149 in 0e08701
kinesis4cats/shared/src/main/scala/kinesis4cats/producer/Producer.scala
Lines 370 to 373 in 0e08701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Introduced
Raise error when there is at least one
invalidrecord. Previously it was only raising when there was at least onefailedrecord.Applicable linked issues
Checklist (check all that apply)