WIP - MetricsReporter for Producers #128
Draft
+629
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etspaceman
commented
May 16, 2023
| import kinesis4cats.compat.retry._ | ||
| import kinesis4cats.logging._ | ||
|
|
||
| abstract class MetricsReporter[F[_], PutRes]( |
There was a problem hiding this comment.
Setting this up very similarly to the FS2Producer, so that we can have a defined, configurable rate of metrics publishing.
etspaceman
commented
May 16, 2023
| unit: StandardUnit | ||
| ) | ||
|
|
||
| object Metric { |
There was a problem hiding this comment.
Metrics defined here are taken from https://docs.aws.amazon.com/streams/latest/dev/monitoring-with-kpl.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Introduced
Introduces
MetricsReporter, with NoOp and CloudWatch variants. CloudWatch will only work for the java client for now as we do not yet have the cloudwatch client set up for the smithy4s client.The intent is to publish the same metrics that the KPL publishes today. See https://docs.aws.amazon.com/streams/latest/dev/monitoring-with-kpl.html
Applicable linked issues
#74
Checklist (check all that apply)