Skip to content

Commit

Permalink
1055 - Added Optional parameter showZeroUsd (#217)
Browse files Browse the repository at this point in the history
* added optional parameter showZeroUsd

* updated version number
  • Loading branch information
vignesha22 authored Feb 20, 2023
1 parent bdee139 commit 3ca8b21
Show file tree
Hide file tree
Showing 7 changed files with 35 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "etherspot",
"version": "1.42.7",
"version": "1.42.8",
"description": "Etherspot SDK",
"keywords": [
"ether",
Expand Down
4 changes: 4 additions & 0 deletions src/sdk/dto/advance-routes-lifi.dto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,8 @@ export class GetAdvanceRoutesLiFiDto {
@IsOptional()
@IsBoolean()
allowSwitchChain?: boolean;

@IsOptional()
@IsBoolean()
showZeroUsd?: boolean;
}
6 changes: 5 additions & 1 deletion src/sdk/dto/get-exchange-cross-chain-quote.dto.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { BigNumber } from 'ethers';
import { Type } from 'class-transformer';
import { IsInt, IsOptional, IsPositive } from 'class-validator';
import { IsBoolean, IsInt, IsOptional, IsPositive } from 'class-validator';
import { IsAddress, IsBigNumberish } from './validators';
import { CrossChainServiceProvider, LiFiBridge } from '..';

Expand Down Expand Up @@ -37,4 +37,8 @@ export class GetExchangeCrossChainQuoteDto {

@IsOptional()
lifiBridges?: LiFiBridge[];

@IsOptional()
@IsBoolean()
showZeroUsd?: boolean;
}
6 changes: 5 additions & 1 deletion src/sdk/dto/get-exchange-offers.dto.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { IsOptional } from 'class-validator';
import { IsBoolean, IsOptional } from 'class-validator';
import { BigNumberish } from 'ethers';
import { IsAddress, IsBigNumberish } from './validators';

Expand All @@ -25,4 +25,8 @@ export class GetExchangeOffersDto {
@IsAddress()
fromAddress?: string;

@IsOptional()
@IsBoolean()
showZeroUsd?: boolean;

}
12 changes: 12 additions & 0 deletions src/sdk/exchange/exchange.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export class ExchangeService extends Service {
lifiBridges?: LiFiBridge[],
toAddress?: string,
fromAddress?: string,
showZeroUsd?: boolean,
): Promise<BridgingQuotes> {
const { apiService, accountService } = this.services;

Expand All @@ -94,6 +95,7 @@ export class ExchangeService extends Service {
$lifiBridges: [LiFiBridge!]
$toAddress: String
$fromAddress: String
$showZeroUsd: Boolean
) {
result: getCrossChainQuotes(
account: $account
Expand All @@ -106,6 +108,7 @@ export class ExchangeService extends Service {
lifiBridges: $lifiBridges
toAddress: $toAddress
fromAddress: $fromAddress
showZeroUsd: $showZeroUsd
) {
items {
provider
Expand Down Expand Up @@ -174,6 +177,7 @@ export class ExchangeService extends Service {
lifiBridges,
toAddress,
fromAddress,
showZeroUsd,
},
models: {
result: BridgingQuotes,
Expand All @@ -193,6 +197,7 @@ export class ExchangeService extends Service {
toAddress?: string,
allowSwitchChain?: boolean,
fromAddress?: string,
showZeroUsd?: boolean,
): Promise<AdvanceRoutesLiFi> {
const { apiService, accountService } = this.services;

Expand All @@ -214,6 +219,7 @@ export class ExchangeService extends Service {
$toAddress: String
$allowSwitchChain: Boolean
$fromAddress: String
$showZeroUsd: Boolean
) {
result: getAdvanceRoutesLiFi(
account: $account
Expand All @@ -225,6 +231,7 @@ export class ExchangeService extends Service {
toAddress: $toAddress
allowSwitchChain: $allowSwitchChain
fromAddress: $fromAddress
showZeroUsd: $showZeroUsd
) {
data
}
Expand All @@ -241,6 +248,7 @@ export class ExchangeService extends Service {
toAddress,
allowSwitchChain,
fromAddress,
showZeroUsd,
},
},
);
Expand Down Expand Up @@ -346,6 +354,7 @@ export class ExchangeService extends Service {
fromChainId: number,
toAddress?: string,
fromAddress?: string,
showZeroUsd?: boolean,
): Promise<ExchangeOffer[]> {
const { apiService, accountService } = this.services;

Expand All @@ -365,6 +374,7 @@ export class ExchangeService extends Service {
$fromAmount: BigNumber!
$toAddress: String
$fromAddress: String
$showZeroUsd: Boolean
) {
result: exchangeOffers(
chainId: $fromChainId
Expand All @@ -374,6 +384,7 @@ export class ExchangeService extends Service {
fromAmount: $fromAmount
toAddress: $toAddress
fromAddress: $fromAddress
showZeroUsd: $showZeroUsd
) {
items {
provider
Expand All @@ -397,6 +408,7 @@ export class ExchangeService extends Service {
fromAmount,
toAddress,
fromAddress,
showZeroUsd,
},
models: {
result: ExchangeOffers,
Expand Down
7 changes: 6 additions & 1 deletion src/sdk/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1351,7 +1351,7 @@ export class Sdk {
* @return Promise<ExchangeOffer[]>
*/
async getExchangeOffers(dto: GetExchangeOffersDto): Promise<ExchangeOffer[]> {
const { fromTokenAddress, toTokenAddress, fromAmount, fromChainId, toAddress, fromAddress } = await validateDto(dto, GetExchangeOffersDto, {
const { fromTokenAddress, toTokenAddress, fromAmount, fromChainId, toAddress, fromAddress, showZeroUsd } = await validateDto(dto, GetExchangeOffersDto, {
addressKeys: ['fromTokenAddress', 'toTokenAddress'],
});

Expand All @@ -1370,6 +1370,7 @@ export class Sdk {
chainId,
toAddress,
fromAddress,
showZeroUsd,
);
}

Expand Down Expand Up @@ -1407,6 +1408,7 @@ export class Sdk {
lifiBridges,
toAddress,
fromAddress,
showZeroUsd,
} = await validateDto(dto, GetExchangeCrossChainQuoteDto, {
addressKeys: ['fromTokenAddress', 'toTokenAddress'],
});
Expand All @@ -1428,6 +1430,7 @@ export class Sdk {
lifiBridges,
toAddress,
fromAddress,
showZeroUsd,
);
}

Expand All @@ -1441,6 +1444,7 @@ export class Sdk {
toAddress,
allowSwitchChain,
fromAddress,
showZeroUsd,
} = await validateDto(dto, GetAdvanceRoutesLiFiDto, {
addressKeys: ['fromTokenAddress', 'toTokenAddress'],
});
Expand All @@ -1457,6 +1461,7 @@ export class Sdk {
toAddress,
allowSwitchChain,
fromAddress,
showZeroUsd,
);

return data;
Expand Down

0 comments on commit 3ca8b21

Please sign in to comment.