-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pro 2160 #34
Pro 2160 #34
Conversation
@@ -1,13 +1,16 @@ | |||
import * as dotenv from 'dotenv'; | |||
dotenv.config(); // init dotenv | |||
import { Factory, PrimeSdk } from '@etherspot/prime-sdk'; | |||
import { EtherspotBundler } from 'ethers'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this valid? Do we have an EtherspotBundler in ethers package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ch4r10t33r Its new implementation is available in the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think its right and I am surprised that they have such a thing if exists @Jineshdarjee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed updated code
@@ -1,13 +1,16 @@ | |||
import * as dotenv from 'dotenv'; | |||
dotenv.config(); // init dotenv | |||
import { Factory, PrimeSdk } from '@etherspot/prime-sdk'; | |||
import { EtherspotBundler } from 'ethers'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see above. I am not sure how this will work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its new implementation is available in the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed updated code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EtherspotBundler class hasn't been implemented in this PR according to the description of the PR
@vignesha22 Added EtherspotBundler implementation in test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description