fix: Remove pauser role #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nugaon
approved these changes
Jul 2, 2024
It would make sense if we have one set of ppl that use multisig for pausing and the other set for general admin with different multisig. Was hard to even get ppl just for admin and to sign things, don't see we will be doing this kind of separation. |
n00b21337
force-pushed
the
remove_pauser_role
branch
from
988264b
to
b2f0da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we currently use the same multistig for pauser and for default admin there is probably no need to have both roles defined and set and then used from the same address. So I am proposing we remove pauser role and just use admin role.