fix: Eliminate local transaction nonce cache. #4839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attila-lendvai
force-pushed
the
nonce-fix
branch
from
c9d14ee
to
b45b8f0
Compare
|
Hi Attila, thanks. This is a nice improvement, but it may need even more changes. The transaction monitor main loop may be problematic and blocking while it does not need to be. This has to be debugged more, but certainly this change is a good step. TestTransactionSend needs to be adjusted as it fails currently. |
attila-lendvai
force-pushed
the
nonce-fix
branch
from
b45b8f0
to
c32c421
Compare
Stop keeping the next nonce in our local state. Instead we always calculate it from the blockchain nonce and the local pending transactions. Fixes issue ethersphere#4826 where the local nonce cache was out of sync with the blockchain for an unknown reason and because of that no transactions got incorporated into the blockchain. This made unstaking or participation in the reserve incentives impossible. Tests adjusted by @martinconic.
attila-lendvai
force-pushed
the
nonce-fix
branch
from
c32c421
to
d1fd469
Compare
martinconic
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: i'm not experienced in golang, and i don't know the bee internals either. this commit requires review by someone who understands the codebase.
Checklist
Description
Stop keeping the next nonce in our local state. Instead we always calculate it from the blockchain nonce and the local list of pending transactions.
Motivation and Context (Optional)
Fixes issue #4826 where the local nonce cache was out of sync with the blockchain for an unknown reason. Because of that no transactions got incorporated into the blockchain. This made it impossible to unstake or to participation in the reserve incentives, probably forever (until fixed).
It only became apparent when i tried to unstake my nodes at the v2.2.0 upgrade, and some of them got stuck. It also explains why i stopped seeing rewards on my nodes.
With this commit on top of v2.1.0 i've successfully unstaked a previously hung node.
And an eternal guiding principle: do not optimize any program until it works as specified. And the only exception is when it's so slow that it substantially hinders development.
A potential unaddressed issue
If a third party creates a transaction, then the bee's transactions may get stuck. There should be a check that the blockchain nonce is lower than the lowest nonce in our pending tx list. If not, then the nonce of the pending tx'es should be updated.