fix: adapt comment to corresponding used value #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janos
approved these changes
Sep 17, 2024
ldeffenb
suggested changes
Sep 18, 2024
acha-bill
approved these changes
Sep 18, 2024
ldeffenb
reviewed
Sep 18, 2024
| @@ -51,7 +51,7 @@ const ( | |||
| pageTimeout = time.Second | |||
| makeOfferTimeout = 15 * time.Minute | |||
| handleMaxChunksPerSecond = 250 | |||
| handleRequestsLimitRate = time.Second / handleMaxChunksPerSecond // handle max 100 chunks per second per peer | |||
| handleRequestsLimitRate = time.Second / handleMaxChunksPerSecond // handle max `handleMaxChunksPerSecond` chunks per second per peer | |||
There was a problem hiding this comment.
I like that much better as it clarifies that the rate is per second per peer (the latter being important) while not being redundant about the actual value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fixes 4823
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):