-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geth): Add debug_traceTransaction RPC method to Geth module #3334
base: main
Are you sure you want to change the base?
Conversation
Thanks! This looks like the right approach. Let me know when this is ready for review! |
Hello, I implemented |
This looks good so far! Do you mind adding some tests? We'll probably want to add a new file to |
Sure, I will try to add test, I will ask you for help if there is any questions. |
@kclowes I have add some tests, please help review if it's ok. |
hi, @kclowes , I have no idea why the py312-core check failed, please have a look. |
|
We're failing on main too, so it's not anything in here. I'm planning to take a look at this PR this week. Thanks for the patience! |
Thanks for getting this going @wangereth! I had to rebase to pull in the latest Geth version. I'll add a newsfragment tomorrow and get this in! |
What was wrong?
Related to Issue #3330
How was it fixed?
debug_traceTransaction
RPC Method firstTodo:
Cute Animal Picture