Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: eth_call for pyevm should not check for known account #297

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

fselmo
Copy link
Contributor

@fselmo fselmo commented Sep 16, 2024

What was wrong?

closes ethereum/web3.py#2198

How was it fixed?

  • Build an unsigned, spoofed tx rather than a signed tx for eth_call via py-evm. The account should not need to be a known account since we aren't signing for eth_call because it does not change state.

Todo:

Cute Animal Picture

1000026487

@fselmo fselmo marked this pull request as ready for review September 16, 2024 22:38
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pacrob
Copy link
Contributor

pacrob commented Sep 17, 2024

This: #211

was opened in relation to the original web3.py issue. Can this close that too?

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original user issue no longer appears. 🐑 it!

@fselmo fselmo merged commit 7946a5b into ethereum:main Sep 18, 2024
24 checks passed
@fselmo fselmo deleted the eth-call-does-not-need-to-be-signed branch September 18, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use contract calls with signing middleware: invalid "from" key error
3 participants