Feat/forkchoice reduction #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djrtwo if you get a chance, I'd love another set of eyes on this bug. It's very weird and I can't figure out why it would possibly happen :D |
|
The above bug is fixed! The fork choice is unfortunately not the same, though. Going to keep debugging + updating the spec for the algo as necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not actually meant to be merged (it was a branch off of the old develop). Just a PoC research type deal. This implements the efficient fork choice functions.
I'm running into this weird, random bug where I can't set the color of the nodes. In the plot tool, I run into the error:
When I print ax.collections, it's an empty list. Not sure why this is the case (displaying worked until I made the changes to view). Is it possible there is a dependancy issue? Not sure.
I can't figure out why changing the view in the way I did would change this would have any effect at all, and have been thrashing for a bit w/ it so thought it would be good to get another pair of eyes on it!