Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rehearsal 5 #239

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Rehearsal 5 #239

wants to merge 20 commits into from

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Jun 19, 2024 •
edited
Loading

Creates a new template for Rehearsal 5.

By following the instructions in the template's README

  1. the facilitator should be able to:
    • deploy a new system to use for the rehearsal
    • generate a new rehearsal task
  2. signers should be able to complete the signing successfully with the generated input.json file.

@maurelian maurelian force-pushed the maur/guardian-rehearsal branch 2 times, most recently from 99b5b78 to dd731d5 Compare June 25, 2024 19:11
@maurelian maurelian marked this pull request as ready for review June 26, 2024 18:19
@maurelian maurelian requested review from a team, zchn and mds1 as code owners June 26, 2024 18:19
mds1
mds1 reviewed Jun 27, 2024
View reviewed changes
foundry.toml Show resolved Hide resolved
mds1
mds1 reviewed Jun 27, 2024
View reviewed changes
script/DeployRehearsal5.s.sol Outdated Show resolved Hide resolved
mds1
mds1 reviewed Jun 27, 2024
View reviewed changes
script/DeployRehearsal5.s.sol Outdated Show resolved Hide resolved
@maurelian maurelian changed the base branch from main to maur/rename-r4-script July 18, 2024 20:19
maurelian
maurelian commented Jul 18, 2024
View reviewed changes
security-council-rehearsals/templates/r5-guardian-override/.env
@@ -0,0 +1,9 @@
# Modify these values according to the Rehearsal instructions
COUNCIL_SAFE=0xAB23dE0DbE0aedF356af3F815c8B47D88575D82d
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This safe is the same as used in previous rehearsals, the SC lead prefers to use it.

maurelian
maurelian commented Jul 18, 2024
View reviewed changes
security-council-rehearsals/templates/r5-guardian-override/.env
# Modify these values according to the Rehearsal instructions
COUNCIL_SAFE=0xAB23dE0DbE0aedF356af3F815c8B47D88575D82d
GuardianSafe_ADDRESS=0x91dCf0F534B36218FE7926eac40089eF54006421
SuperchainConfig_ADDRESS=0xbEDBB0A4d75514c84D569977B14D400c2Af5b36D
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been unable to verify either the Proxy or Implementation for this contract.

@maurelian maurelian requested a review from a team as a code owner July 26, 2024 19:31
Base automatically changed from maur/rename-r4-script to main July 29, 2024 18:01
@maurelian maurelian mentioned this pull request Jul 29, 2024
Merged
@maurelian maurelian marked this pull request as draft August 1, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 left review comments

@zchn zchn Awaiting requested review from zchn

@sbvegan sbvegan Awaiting requested review from sbvegan

@blmalone blmalone Awaiting requested review from blmalone

@awilliams1-cb awilliams1-cb Awaiting requested review from awilliams1-cb

@anikaraghu anikaraghu Awaiting requested review from anikaraghu

@emrahCoinbase emrahCoinbase Awaiting requested review from emrahCoinbase

At least 1 approving review is required to merge this pull request.

Assignees

@mds1 mds1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurelian @mds1