Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint(ci): add kontrol build to CI #12266

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

smartcontracts
Copy link
Contributor

Adds Kontrol summary build back into CI just to verify that it functions correctly. In line with our recent CI changes this task still does not enforce that the build summary be checked in.

@smartcontracts smartcontracts force-pushed the sc/ci-kontrol-build branch 5 times, most recently from 205173c to c207cdf Compare October 2, 2024 19:57
@smartcontracts smartcontracts marked this pull request as ready for review October 2, 2024 20:05
@smartcontracts smartcontracts requested a review from a team as a code owner October 2, 2024 20:05
@smartcontracts
Copy link
Contributor Author

PR fails as expected, should pass once I rebase...

Adds Kontrol summary build back into CI just to verify that it
functions correctly. In line with our recent CI changes this
task still does not enforce that the build summary be checked in.
@smartcontracts smartcontracts requested review from mds1 and removed request for bitwiseguy October 2, 2024 20:37
@smartcontracts smartcontracts added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit daff281 Oct 2, 2024
63 checks passed
@smartcontracts smartcontracts deleted the sc/ci-kontrol-build branch October 2, 2024 22:40
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.00%. Comparing base (91f67eb) to head (abdbad4).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12266      +/-   ##
===========================================
- Coverage    72.21%   72.00%   -0.21%     
===========================================
  Files           50       50              
  Lines         3912     3912              
===========================================
- Hits          2825     2817       -8     
- Misses         901      910       +9     
+ Partials       186      185       -1     
Flag Coverage Δ
cannon-go-tests 72.00% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

mininny pushed a commit to testinprod-io/optimism that referenced this pull request Oct 3, 2024
Adds Kontrol summary build back into CI just to verify that it
functions correctly. In line with our recent CI changes this
task still does not enforce that the build summary be checked in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants