Skip to content

Commit

Permalink
ci: job to check contracts build warnings (#11962)
Browse files Browse the repository at this point in the history
Adds a new compiler job to check for contract build warnings.
Other existing build jobs don't compile the entire set of contracts
and we do want to be able to check for warnings across the board.
  • Loading branch information
smartcontracts authored Sep 18, 2024
1 parent 9de48fc commit c186b48
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,7 @@ jobs:
parameters:
build_command:
type: string
default: |
just prebuild
forge build --deny-warnings
default: just build
steps:
- checkout
- install-contracts-dependencies
Expand Down Expand Up @@ -1616,10 +1614,8 @@ workflows:
jobs:
- go-mod-download
- contracts-bedrock-build:
name: contracts-bedrock-build
build_command: |
# Note: scripts are included, to be available to op-e2e
forge build --skip test
# Build with just core + script contracts.
build_command: forge build --skip test --deny-warnings
- contracts-bedrock-tests:
# Test everything except PreimageOracle.t.sol since it's slow.
name: contracts-bedrock-tests
Expand All @@ -1629,12 +1625,12 @@ workflows:
TEST_FILES=$(echo "$TEST_FILES" | circleci tests split --split-by=timings)
TEST_FILES=$(echo "$TEST_FILES" | sed 's|./test/||')
MATCH_PATH="./test/{$(echo "$TEST_FILES" | paste -sd "," -)}"
forge test --match-path "$MATCH_PATH"
forge test --deny-warnings --match-path "$MATCH_PATH"
- contracts-bedrock-tests:
# PreimageOracle test is slow, run it separately to unblock CI.
name: contracts-bedrock-tests-preimage-oracle
test_parallelism: 1
test_command: forge test --match-path ./test/cannon/PreimageOracle.t.sol
test_command: forge test --deny-warnings --match-path ./test/cannon/PreimageOracle.t.sol
- contracts-bedrock-tests:
# Heavily fuzz any fuzz tests that have been added or modified.
name: contracts-bedrock-tests-heavy-fuzz-modified
Expand Down Expand Up @@ -2141,7 +2137,10 @@ workflows:
- cannon-prestate:
requires:
- go-mod-download
- contracts-bedrock-build
- contracts-bedrock-build:
build_command: forge build --skip test
context:
- slack
- go-e2e-test:
name: op-e2e-cannon-tests<< matrix.variant >>
matrix:
Expand Down

0 comments on commit c186b48

Please sign in to comment.