Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unsafe lifecycle #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dan-lee
Copy link

@dan-lee dan-lee commented Nov 9, 2019

This is to fix the following warning and to be compatible with concurrent mode:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

It shouldn't affect the functionality, but I didn't test it. I converted some other components in the similar manner and it always worked out.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 746df2b on dan-lee:patch-1 into 0f594bb on ethanselzer:master.

@dan-lee
Copy link
Author

dan-lee commented Apr 3, 2020

@ethanselzer Any chance getting this in soon? ✌️

@geoguide
Copy link

geoguide commented Nov 12, 2020

Can we get this merged and released? It's been ready for over a year.

@dan-lee
Copy link
Author

dan-lee commented Nov 18, 2020

@geoguide Btw. there's always the option to use patch-package, which is my go-to tool to deal with situations like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants