Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: if 'max_conversions' limit is reached but there are unconverted dependencies left, prompt user to continue conversion #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: if 'max_conversions' limit is reached but there are unconverted dependencies left, prompt user to continue conversion #11

wants to merge 4 commits into from

Conversation

davhofer
Copy link
Collaborator

@davhofer davhofer commented Sep 2, 2024

No description provided.

@davhofer
feat: if 'max_conversions' limit is reached but there are unconverted…
dcb3177 
… dependencies, prompt user to continue conversion
@davhofer
Copy link
Collaborator Author

davhofer commented Sep 2, 2024

Functionally correct, tests fail because program tries to get user input from stdin during testing.

@davhofer
Copy link
Collaborator Author

davhofer commented Sep 2, 2024

CLI for this feature could be improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davhofer