[3.4] release: push tag after creating it #18587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanvc
changed the title
jmhbnz
reviewed
Sep 14, 2024
Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
force-pushed
the
release-3.4-release-push-tag
branch
from
5900df1
to
6e5a60e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in #18486 (comment), running release-3.4's release script created the tag but didn't push it. This pull request addresses that issue.
I verified this by running the script with my fork and pointing the
REPOSITORYenvironment variable to it:version/version.gobump commit: ivanvc@d2e6638Part of #18486
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.