[2024-09-11] Bump dependency updates identified by dependabot #18575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #18575 +/- ##
==========================================
+ Coverage 68.73% 68.84% +0.11%
==========================================
Files 420 420
Lines 35474 35474
==========================================
+ Hits 24382 24422 +40
+ Misses 9666 9630 -36
+ Partials 1426 1422 -4 Continue to review full report in Codecov by Sentry.
|
|
/retest |
|
Looks like there is an issue with one of the dependencies. I will check in a bit to fix the CI |
Reference: - etcd-io#18562 - etcd-io#18567 Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
force-pushed
the
dependencies/09_11_24
branch
3 times, most recently
from
3b9b43a
to
636f191
Compare
….20.3 Reference: - etcd-io#18564 - etcd-io#18559 Signed-off-by: Chun-Hung Tseng <[email protected]>
golang.org/x/sys and golang.org/x/text version inconsistency are also addressed: - bump golang.org/x/sys from 0.24.0 to 0.25.0 - bump golang.org/x/text from 0.17.0 to 0.18.0 Reference: - etcd-io#18563 - etcd-io#18558 - etcd-io#18566 - etcd-io#18565 Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
force-pushed
the
dependencies/09_11_24
branch
from
e824656
to
14d5489
Compare
Fixed, cc @ivanvc |
henrybear327
added a commit
to henrybear327/etcd
that referenced
this pull request
Sep 14, 2024
As module_dirs also contains the go.mod file. We should add it into the module_dirs variable, so when executing ./scripts/fix.sh, the proper checks and fixes can be applied. Discovered when working on etcd-io#18575 The directories are checked against the following: [Command] find . -type f -name go.mod -exec dirname {} \; [Output] ./etcdutl . ./tools/testgrid-analysis ./tools/rw-heatmaps ./tools/mod ./etcdctl ./tests ./server ./api ./client/internal/v2 ./client/v3 ./client/pkg ./pkg Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
added a commit
to henrybear327/etcd
that referenced
this pull request
Sep 14, 2024
As `tools/mod` also contains the `go.mod` file. We should add it to the `module_dirs` variable, so that when executing `./scripts/fix.sh`, the proper checks and fixes can be applied. Discovered when working on etcd-io#18575 The directories are checked against the following: - Command: `find . -type f -name go.mod -exec dirname {} \;` - Output: ``` ./etcdutl . ./tools/testgrid-analysis ./tools/rw-heatmaps ./tools/mod ./etcdctl ./tests ./server ./api ./client/internal/v2 ./client/v3 ./client/pkg ./pkg ``` Signed-off-by: Chun-Hung Tseng <[email protected]>
|
/cc @ahrtr |
ahrtr
approved these changes
Sep 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, henrybear327, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
henrybear327
added a commit
to henrybear327/etcd
that referenced
this pull request
Sep 16, 2024
As `tools/mod` also contains the `go.mod` file. We should add it to the `module_dirs` variable, so that when executing `./scripts/fix.sh`, the proper checks and fixes can be applied. Discovered when working on etcd-io#18575 The directories are checked against the following: - Command: `find . -type f -name go.mod -exec dirname {} \;` - Output: ``` ./etcdutl . ./tools/testgrid-analysis ./tools/rw-heatmaps ./tools/mod ./etcdctl ./tests ./server ./api ./client/internal/v2 ./client/v3 ./client/pkg ./pkg ``` Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
added a commit
to henrybear327/etcd
that referenced
this pull request
Sep 16, 2024
As `tools/mod` also contains the `go.mod` file. We should add it to the `module_dirs` variable, so that when executing `./scripts/fix.sh`, the proper checks and fixes can be applied. To address the issue of broken unit tests and code coverage due to the directory's lack of Go code, we've introduced a new mod.go file. This file acts as a placeholder, enabling tools like golangci-lint and go test to function correctly. --- Discovered when working on etcd-io#18575 The directories are checked against the following: - Command: `find . -type f -name go.mod -exec dirname {} \;` - Output: ``` ./etcdutl . ./tools/testgrid-analysis ./tools/rw-heatmaps ./tools/mod ./etcdctl ./tests ./server ./api ./client/internal/v2 ./client/v3 ./client/pkg ./pkg ``` Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
added a commit
to henrybear327/etcd
that referenced
this pull request
Sep 16, 2024
As `tools/mod` also contains the `go.mod` file. We should add it to the `module_dirs` variable, so that when executing `./scripts/fix.sh`, the proper checks and fixes can be applied. To address the issue of broken unit tests and code coverage due to the directory's lack of Go code, we've introduced a new mod.go file. This file acts as a placeholder, enabling tools like golangci-lint and go test to function correctly. --- Discovered when working on etcd-io#18575 The directories are checked against the following: - Command: `find . -type f -name go.mod -exec dirname {} \;` - Output: ``` ./etcdutl . ./tools/testgrid-analysis ./tools/rw-heatmaps ./tools/mod ./etcdctl ./tests ./server ./api ./client/internal/v2 ./client/v3 ./client/pkg ./pkg ``` Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
added a commit
to henrybear327/etcd
that referenced
this pull request
Sep 17, 2024
As `tools/mod` also contains the `go.mod` file. We should add it to the `module_dirs` variable, so that when executing `./scripts/fix.sh`, the proper checks and fixes can be applied. To address the issue of broken unit tests and code coverage due to the directory's lack of Go code, we've introduced a new doc.go file. This file acts as a placeholder, enabling tools like golangci-lint and go test to function correctly. --- Discovered when working on etcd-io#18575 The directories are checked against the following: - Command: `find . -type f -name go.mod -exec dirname {} \;` - Output: ``` ./etcdutl . ./tools/testgrid-analysis ./tools/rw-heatmaps ./tools/mod ./etcdctl ./tests ./server ./api ./client/internal/v2 ./client/v3 ./client/pkg ./pkg ``` Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
added a commit
to henrybear327/etcd
that referenced
this pull request
Sep 18, 2024
As `tools/mod` also contains the `go.mod` file. We should add it to the `module_dirs` variable, so that when executing `./scripts/fix.sh`, the proper checks and fixes can be applied. To address the issue of broken unit tests and code coverage due to the directory's lack of Go code, we've introduced a new doc.go file. This file acts as a placeholder, enabling tools like golangci-lint and go test to function correctly. --- Discovered when working on etcd-io#18575 The directories are checked against the following: - Command: `find . -type f -name go.mod -exec dirname {} \;` - Output: ``` ./etcdutl . ./tools/testgrid-analysis ./tools/rw-heatmaps ./tools/mod ./etcdctl ./tests ./server ./api ./client/internal/v2 ./client/v3 ./client/pkg ./pkg ``` Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
added a commit
to henrybear327/etcd
that referenced
this pull request
Sep 18, 2024
As `tools/mod` also contains the `go.mod` file. We should add it to the `module_dirs` variable, so that when executing `./scripts/fix.sh`, the proper checks and fixes can be applied. To address the issue of broken unit tests and code coverage due to the directory's lack of Go code, we've introduced a new doc.go file. This file acts as a placeholder, enabling tools like golangci-lint and go test to function correctly. --- Discovered when working on etcd-io#18575 The directories are checked against the following: - Command: `find . -type f -name go.mod -exec dirname {} \;` - Output: ``` ./etcdutl . ./tools/testgrid-analysis ./tools/rw-heatmaps ./tools/mod ./etcdctl ./tests ./server ./api ./client/internal/v2 ./client/v3 ./client/pkg ./pkg ``` Signed-off-by: Chun-Hung Tseng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.
Summary of actions
Bumped
Fully indirect
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.