clientv3: remove the experimental gRPC API grpccredentials.Bundle #16358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
force-pushed
the
remove_creds_bundle_20230802
branch
from
69c98f9
to
0c22047
Compare
Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
remove_creds_bundle_20230802
branch
from
0c22047
to
979102f
Compare
jmhbnz
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Makes sense, and good discovery @chaochn47.
Should this change be backported? Both prior release branches also use this api.
|
Right, usually we don't proactively bump dependencies for stable release (e.g. 3.5 and 3.4) unless there are major CVE or bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to #15145
The credentials.Bundle is an experimental API. We should try to remove the dependency on such experimental gRPC API.
Actually transport credential and per GRPC credentials are two different things, no need to get them bind together.