Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump arduino/setup-protoc from 1.3.0 to 2.0.0 #16016

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 5, 2023

Bumps arduino/setup-protoc from 1.3.0 to 2.0.0.

Release notes

Sourced from arduino/setup-protoc's releases.

v2.0.0

Changelog

Adding support for the MINOR.PATCH tag naming

Breaking

Full Changelog: arduino/setup-protoc@v1.3.0...v2.0.0

Contributors

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [arduino/setup-protoc](https://github.com/arduino/setup-protoc) from 1.3.0 to 2.0.0.
- [Release notes](https://github.com/arduino/setup-protoc/releases)
- [Commits](arduino/setup-protoc@149f6c8...9b1ee5b)

---
updated-dependencies:
- dependency-name: arduino/setup-protoc
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jun 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #16016 (7c34ad8) into main (cdbc2c1) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main   #16016      +/-   ##
==========================================
- Coverage   69.99%   69.84%   -0.16%     
==========================================
  Files         414      414              
  Lines       34779    34779              
==========================================
- Hits        24344    24290      -54     
- Misses       9055     9105      +50     
- Partials     1380     1384       +4     
Flag Coverage Δ
all 69.84% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahrtr
Copy link
Member

ahrtr commented Jun 6, 2023

Not sure whether or not the workflow failures are related to arduino/setup-protoc#9

@jmhbnz
Copy link
Member

jmhbnz commented Jun 6, 2023

Not sure whether or not the workflow failures are related to arduino/setup-protoc#9

Looks like it might be, can we bump the version here? https://github.com/etcd-io/etcd/pull/16016/files#diff-5d68f6ca696b457d708e1895ce1dcab8820f9d6d9357b3876176cbcdd9808b98L23

If we go to https://api.github.com/repos/protocolbuffers/protobuf/releases and filter json by tag_name then hit "expand all" you will see that 3.14 version we are using is no longer in first page of results.

Edit: Lowest release displayed in first page appears to be v3.16.3.

@ahrtr
Copy link
Member

ahrtr commented Jun 6, 2023

Looks like it might be

Yes, the symptoms is similar. But it seems that the issue has already been fixed by in arduino/setup-protoc#9. So I am a little confused why we still run into this issue after bumping to arduino/setup-protoc 2.0.0. It seems that I missed something.

can we bump the version here? https://github.com/etcd-io/etcd/pull/16016/files#diff-5d68f6ca696b457d708e1895ce1dcab8820f9d6d9357b3876176cbcdd9808b98L23

It may be related to #14533. We will bump it eventually, but It isn't an easy task.

@chaochn47
Copy link
Member

I am taking a look to investigate why upgrading v2.0.0 breaks the workflow. Enable verbose debug logging may be helpful. https://github.com/arduino/setup-protoc#enable-verbose-logging-for-a-pipeline

@chaochn47
Copy link
Member

chaochn47 commented Jun 6, 2023

arduino/setup-protoc v2.0.0 introduces a breaking change: Support only the new protobuf versioning scheme and the release manager recommends projects that depend on old protoc version (like us v3.14.0) uses v1 in arduino/setup-protoc#78 (comment)

So, it is related to #14533.

@ahrtr
Copy link
Member

ahrtr commented Jun 7, 2023

Thanks @chaochn47 . So closing this PR for now, and bump arduino/setup-protoc after we fix #14533?

@ahrtr ahrtr closed this Jun 7, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 7, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/arduino/setup-protoc-2.0.0 branch June 7, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Development

Successfully merging this pull request may close these issues.

4 participants