Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project cleanup, Manual build and upload #25

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

jakub-kocka
Copy link
Collaborator

@jakub-kocka jakub-kocka commented Jan 11, 2024

  • Cleanuped the project repository
  • Added manual build and upload for specified platforms, architectures and wheel(s)
  1. All platforms and architectures workflow
  2. Specified platforms and architectures worflow
  • README.md was updated to explain how to use build-wheels-defined.yml (manual wheel(s) build and upload)

  • Also os_dependencies directory was explained in README.md

  • Upload workflow moved to reusable workflow - succeful run

Related

Copy link

github-actions bot commented Jan 11, 2024

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).
📖 This PR seems to be quite large (total lines of code: 1366), you might consider splitting it into smaller PRs

👋 Hello jakub-kocka, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 802a865

@jakub-kocka jakub-kocka marked this pull request as draft January 12, 2024 09:15
@jakub-kocka jakub-kocka force-pushed the feat/project_cleanup branch 7 times, most recently from 4fc968d to 0ccc440 Compare January 12, 2024 13:35
@jakub-kocka jakub-kocka changed the title Project cleanup, Fix for index page creation Project cleanup Jan 12, 2024
@jakub-kocka jakub-kocka force-pushed the feat/project_cleanup branch 3 times, most recently from d1f3e9e to ed444da Compare January 15, 2024 14:32
@jakub-kocka jakub-kocka changed the title Project cleanup Project cleanup, Manual build and upload Jan 16, 2024
Copy link
Member

@tomassebestik tomassebestik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jakub-kocka

@jakub-kocka jakub-kocka marked this pull request as ready for review January 19, 2024 08:00
Copy link
Collaborator

@fhrbata fhrbata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@jakub-kocka
Copy link
Collaborator Author

@dobairoland, Can you please take a look? If everything is OK, MR is ready to merge.

@dobairoland dobairoland merged commit 0090a6e into main Jan 23, 2024
1 check passed
@dobairoland dobairoland deleted the feat/project_cleanup branch January 23, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ideas for future project improvements (IDF-8066)
4 participants