Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new OTA method #754

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

smarthomesnowy
Copy link

Added new OTA method and a new "standard" default example code.

Added new OTA method and a new "standard" default example code.
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 1fbc615
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/667c919d432edd00085dd826
😎 Deploy Preview https://deploy-preview-754--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 81 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things:

Lets not change the names an friendly names since these configs are for specific devices and the existing ones make sense.

Also, lets not remove captive_portal because if people can only ota flash a device and dont add wifi credentials, it will be difficult to update it again.

@esphome esphome bot marked this pull request as draft June 25, 2024 09:58
@esphome
Copy link

esphome bot commented Jun 25, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@smarthomesnowy
Copy link
Author

A few things:

Lets not change the names an friendly names since these configs are for specific devices and the existing ones make sense.

Also, lets not remove captive_portal because if people can only ota flash a device and dont add wifi credentials, it will be difficult to update it again.

OK I will keep that in mind and revert the couple that changed the friendly names. Will keep in captive_portal if it is there already.

Added the captive_portal: to standard code block
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants