Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move-intro-to-git-from-swcarpentry #3

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

lyashevska
Copy link
Contributor

@lyashevska lyashevska commented Jun 3, 2024

@lyashevska lyashevska self-assigned this Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/git-lesson/compare/md-outputs..md-outputs-PR-3

The following changes were observed in the rendered markdown documents:

 02-setup.md (new)                                  | 225 ++++++
 03-create.md (new)                                 | 217 ++++++
 04-changes.md (new)                                | 795 +++++++++++++++++++++
 05-history.md (new)                                | 625 ++++++++++++++++
 06-ignore.md (new)                                 | 374 ++++++++++
 07-github.md (new)                                 | 555 ++++++++++++++
 ...-git-centralized.md => 08-collab-centralized.md |   0
 ...-git-distributed.md => 09-collab-distributed.md |   0
 config.yaml                                        |  11 +-
 fig/git-checkout.svg (new +x)                      | 111 +++
 fig/git-committing.svg (new +x)                    | 436 +++++++++++
 fig/git-freshly-made-github-repo.svg (new +x)      | 315 ++++++++
 fig/git-staging-area.svg (new +x)                  |  93 +++
 fig/git_staging.svg (new +x)                       | 675 +++++++++++++++++
 fig/github-change-repo-string.png (new +x)         | Bin 0 -> 71251 bytes
 fig/github-create-repo-01.png (new +x)             | Bin 0 -> 33386 bytes
 fig/github-create-repo-02.png (new +x)             | Bin 0 -> 256710 bytes
 fig/github-create-repo-03.png (new +x)             | Bin 0 -> 271273 bytes
 fig/github-find-repo-string.png (new +x)           | Bin 0 -> 75291 bytes
 fig/github-repo-after-first-push.svg (new +x)      | 483 +++++++++++++
 fig/merge.svg (new +x)                             | 122 ++++
 fig/motivatingexample.png (new +x)                 | Bin 0 -> 965220 bytes
 fig/phd101212s.png (new +x)                        | Bin 0 -> 83764 bytes
 fig/play-changes.svg (new +x)                      | 175 +++++
 fig/versions.svg (new +x)                          | 247 +++++++
 introduction.md (gone)                             | 125 ----
 md5sum.txt                                         |  13 +-
 27 files changed, 5465 insertions(+), 132 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-06-04 10:58:27 +0000

Copy link
Contributor

@svenvanderburg svenvanderburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @lyashevska! Just one comment: Can you remove all images that we do not need?

@lyashevska
Copy link
Contributor Author

Thanks for the review and spotting unused figures @svenvanderburg. This should be fixed now.

@lyashevska
Copy link
Contributor Author

This can be merged now. Failed checks were reported here

github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
@lyashevska
Copy link
Contributor Author

All issues were fixed now.

@lyashevska lyashevska merged commit f3061cc into main Jun 4, 2024
3 checks passed
@lyashevska lyashevska deleted the 36-move-intro-to-git branch June 4, 2024 11:02
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : f3061cc
Branch  : main
Author  : Olga Lyashevska <[email protected]>
Time    : 2024-06-04 11:02:40 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/36-move-intro-to-git

Move-intro-to-git-from-swcarpentry
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : b3adb9f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 11:03:36 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f3061cc
Branch  : main
Author  : Olga Lyashevska <[email protected]>
Time    : 2024-06-04 11:02:40 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/36-move-intro-to-git

Move-intro-to-git-from-swcarpentry
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Auto-generated via {sandpaper}
Source  : b3adb9f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 11:03:36 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f3061cc
Branch  : main
Author  : Olga Lyashevska <[email protected]>
Time    : 2024-06-04 11:02:40 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/36-move-intro-to-git

Move-intro-to-git-from-swcarpentry
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
Auto-generated via {sandpaper}
Source  : b3adb9f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 11:03:36 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f3061cc
Branch  : main
Author  : Olga Lyashevska <[email protected]>
Time    : 2024-06-04 11:02:40 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/36-move-intro-to-git

Move-intro-to-git-from-swcarpentry
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
Auto-generated via {sandpaper}
Source  : b3adb9f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 11:03:36 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f3061cc
Branch  : main
Author  : Olga Lyashevska <[email protected]>
Time    : 2024-06-04 11:02:40 +0000
Message : Merge pull request #3 from esciencecenter-digital-skills/36-move-intro-to-git

Move-intro-to-git-from-swcarpentry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Introduction to git to the new workbench lesson
2 participants